Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg.develop(PackageSpec(path=$(local repo))) does not build the package #862

Open
bicycle1885 opened this Issue Oct 29, 2018 · 4 comments

Comments

3 participants
@bicycle1885
Copy link

bicycle1885 commented Oct 29, 2018

Pkg.develop(PackageSpec(path="local repository")) does not build the package while Pkg.develop(PackageSpec(url="remote repository")) does. I noticed this while working on the migration of documentation deployment (see https://discourse.julialang.org/t/psa-use-a-project-for-building-your-docs/14974/11 for details). This may be intentional but this is unexpected to me.

@00vareladavid

This comment has been minimized.

Copy link
Collaborator

00vareladavid commented Dec 3, 2018

I don't think this is intended, but this should be fixed on master: We map path to url during the construction of PackageSpec so there is not much room for both commands to become out of sync.

maleadt added a commit to JuliaGPU/GPUArrays.jl that referenced this issue Dec 11, 2018

@00vareladavid

This comment has been minimized.

Copy link
Collaborator

00vareladavid commented Feb 1, 2019

Actually, I think this is intended. We only build new downloads. Perhaps we should info? e.g. Skipping build for package `Foo`. Run `build(PackageSpec(;name="Foo"))` to force build.

@fredrikekre

This comment has been minimized.

Copy link
Member

fredrikekre commented Feb 1, 2019

Perhaps we should info?

It could be annoying. Maybe just document that develop just points to the existing files? Or maybe detect that the package has a build script and only warn then.

@00vareladavid

This comment has been minimized.

Copy link
Collaborator

00vareladavid commented Feb 1, 2019

Definitely can be annoying, especially for big environments.
Perhaps we can mitigate the annoyingness by displaying all at once?

For example:

Skiping build for: name[short_uuid] name2[short_uuid] ...

@00vareladavid 00vareladavid added the build label Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.