remove preview command #1367
Merged
remove preview command #1367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
bors try |
fredrikekre
approved these changes
Sep 10, 2019
Contributor
tryBuild succeeded |
Contributor
|
I think this will close #996 |
Member
Author
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 10, 2019
1367: remove preview command r=KristofferC a=KristofferC `preview` had good intentions. By allowing to check what happened when executing a command without it taking effect, it was intended for the user to avoid pkg commands that mess up their project. However, in practice, no one think they will do a mistake so no one uses preview. It is also quite invasive in the code base. You constantly need to think if you are running things in preview mode and in that case try to emulate the normal usage but at the same time don't do any persistent mutations. What is needed is instead `undo` + `redo`. This just removes `preview` and I will implement `undo` + `redo` to replace it (unless someone beats me to it) Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Contributor
|
For what is worth, I religiously used preview to see the versions of updated packages and whether or not potential updates introduced breaking changes. Can this be achieved any other way? As for undo/redo wouldn't that be just versioning Manifest.toml (potentially using Git)? |
Member
Author
|
With the undo redo it would just be It would be "versioning" but in memory and not as painful as having to commit all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previewhad good intentions. By allowing to check what happened when executing a command without it taking effect, it was intended for the user to avoid pkg commands that mess up their project. However, in practice, no one think they will do a mistake so no one uses preview. It is also quite invasive in the code base. You constantly need to think if you are running things in preview mode and in that case try to emulate the normal usage but at the same time don't do any persistent mutations.What is needed is instead
undo+redo. This just removespreviewand I will implementundo+redoto replace it (unless someone beats me to it)