Skip to content

add an API option to ignore compat #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add an API option to ignore compat #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/Operations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ function resolve_versions!(ctx::Context, pkgs::Vector{PackageSpec})
for pkg in pkgs
compat = project_compatibility(ctx, pkg.name)
v = intersect(pkg.version, compat)
if isempty(v)
if !ctx.ignore_compat && isempty(v)
throw(Resolve.ResolverError(
"empty intersection between $(pkg.name)@$(pkg.version) and project compatibility $(compat)"))
end
Expand Down Expand Up @@ -422,11 +422,13 @@ function deps_graph(ctx::Context, uuid_to_name::Dict{UUID,String}, reqs::Resolve
other_uuid in uuids || push!(uuids, other_uuid)
end
end
for (vr, cd) in compat_data
all_compat_u_vr = get_or_make!(all_compat_u, vr)
for (name,vs) in cd
# check conflicts??
all_compat_u_vr[name] = vs
if !ctx.ignore_compat
Copy link
Member

@DilumAluthge DilumAluthge Dec 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if !ctx.ignore_compat
if ctx.ignore_compat
@warn "You are using the ignore_compat feature. Use of this feature may cause packages to break. It is the responsibility of the user (not the maintainers of any packages) to solve any problems that arise from the use of this feature." maxlog = 1
else

for (vr, cd) in compat_data
all_compat_u_vr = get_or_make!(all_compat_u, vr)
for (name,vs) in cd
# check conflicts??
all_compat_u_vr[name] = vs
end
end
end
end
Expand Down
1 change: 1 addition & 0 deletions src/Types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,7 @@ Base.@kwdef mutable struct Context
# the future. It currently stands as an unofficial workaround for issue #795.
num_concurrent_downloads::Int = haskey(ENV, "JULIA_PKG_CONCURRENCY") ? parse(Int, ENV["JULIA_PKG_CONCURRENCY"]) : 8
graph_verbose::Bool = false
ignore_compat::Bool = false
currently_running_target::Bool = false
end

Expand Down