Clean up jl_XXX-download.gz.sha256 files
#1840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because PlatformEngines assumes you may want to verify a tarball later, it spits out `.sha256` files to optimize for hashing in the future. This is fine when you're downloading to a permanent location or a directory that was created by `mktempdir()`, but if your download location is just a file sitting in `/tmp` which you clean up manually afterward, you need to clean up that `.sha256` file as well.
fredrikekre
reviewed
May 28, 2020
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
fredrikekre
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because PlatformEngines assumes you may want to verify a tarball later, it spits out
.sha256files to optimize for hashing in the future. This is fine when you're downloading to a permanent location or a directory that was created bymktempdir(), but if your download location is just a file sitting in/tmpwhich you clean up manually afterward, you need to clean up that.sha256file as well.