-
-
Notifications
You must be signed in to change notification settings - Fork 285
RFC: add add_artifact! function
#1951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@staticfloat Could you take a quick look at this? Just to know whether this is the right direction. |
|
Can you explain a bit what the purpose of this function is? Is this to make it easier to download a pre-existing tarball and bind it as an artifact? |
|
Yes exactly! I found it quite cumbersome with the current API to just ship a tarball that's already hosted somewhere as an artifact, especially when you want to update it periodically. This aims to provide this functionality, so the package developer doesn't have to worry about calculating all the correct checksums manually. |
|
I wonder if we shouldn't have an external |
|
An external package is also fine. I believe many people (mis)use BinaryBuilder to create JLL packages because that's the easiest way to create an Artifacts.toml |
|
Is that something that should live under the JuliaLang or JuliaPackaging umbrella, with the goal of factoring out some of BinaryBuilder's functionality into such a package or should I just go ahead and put this into a package of my own? |
|
I think an |
|
This was pointed out to me. Looks like exactly what I needed, but also happy to use a separate package if it is existed. |
|
@giordano Should I just go ahead and start a package for this, or do you have grander plans in terms of factoring out parts of BinaryBuilder? |
|
No, we don't have any plan about this at the moment |
|
@jlperla I started a package here: https://github.com/simeonschaub/ArtifactUtils.jl Should also (hopefully) be registered soon. |
This is just an initial prototype and doesn't have tests and docs yet. Is this the right way to do this? Should there be an option for multiple
tarball_urls as well?Closes #1950