Skip to content

Conversation

@ranocha
Copy link
Member

@ranocha ranocha commented Aug 26, 2022

This should hopefully fix some invalidations coming from Static.jl.

Here is the code:
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.8.0 (2022-08-17)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

(@v1.8) pkg> activate --temp

(jl_PDrBpd) pkg> add Static
    Updating registry at `~/.julia/registries/General.toml`
   Resolving package versions...
    Updating `/tmp/jl_PDrBpd/Project.toml`
  [aedffcd0] + Static v0.7.6
    Updating `/tmp/jl_PDrBpd/Manifest.toml`
  [615f187c] + IfElse v0.1.1
  [aedffcd0] + Static v0.7.6

julia> using SnoopCompileCore

julia> invalidations = @snoopr using Static

julia> using SnoopCompile

julia> trees = invalidation_trees(invalidations)
7-element Vector{SnoopCompile.MethodInvalidations}:
...
inserting ifelse(::False, x, y) in Static at ~/.julia/packages/Static/sVI3g/src/Static.jl:88 invalidated:
...
                 7: signature Tuple{typeof(ifelse), Any, DateTime, Any} triggered MethodInstance for max(::DateTime, ::Any) (31 children)

julia> ftrees = filtermod(Pkg.API, trees)
1-element Vector{SnoopCompile.MethodInvalidations}:
 inserting !(::False) in Static at ~/.julia/packages/Static/sVI3g/src/Static.jl:427 invalidated:
   mt_backedges: 1: signature Tuple{typeof(!), Any} triggered MethodInstance for (::Pkg.API.var"#write_condensed_toml#182")(::Pkg.API.var"#153#184"{Set{String}}, ::Dict{String, Dict{String, DateTime}}, ::String) (0 children)
                 2: signature Tuple{typeof(!), Any} triggered MethodInstance for (::Pkg.API.var"#write_condensed_toml#182")(::Pkg.API.var"#156#187"{Set{String}}, ::Dict{String, Dict{String, DateTime}}, ::String) (0 children)
                 3: signature Tuple{typeof(!), Any} triggered MethodInstance for (::Pkg.API.var"#write_condensed_toml#182")(::Pkg.API.var"#159#190"{Dict{String, Dict{String, Set{String}}}, Set{String}, Set{String}}, ::Dict{String, Dict{String, DateTime}}, ::String) (0 children)

@KristofferC KristofferC merged commit aa3704d into JuliaLang:master Aug 26, 2022
@ranocha ranocha deleted the patch-2 branch August 26, 2022 15:09
KristofferC pushed a commit that referenced this pull request Aug 30, 2022
* fix API invalidations from Static.jl

(cherry picked from commit aa3704d)
KristofferC pushed a commit that referenced this pull request Sep 21, 2022
* fix API invalidations from Static.jl

(cherry picked from commit aa3704d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants