Artifacts: Add download size to Artifacts.toml
#4171
Merged
+63
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhz2
reviewed
Feb 25, 2025
Member
|
I made JuliaPackaging/ArtifactUtils.jl#25 to try this out. |
Member
How common is this? Is there any concrete case of this happening right now? |
Member
|
Very important bikeshedding question: should the "size" field be in hex or base 10? For example: |
Member
Author
|
We don't put anything else in hex, I think we should just stick with the most human-readable format. |
nhz2
reviewed
Mar 8, 2025
| "sha256" => bytes2hex(adi.hash), | ||
| ) | ||
| if adi.size > 0 | ||
| ret["size"] = adi.size |
Member
There was a problem hiding this comment.
Suggested change
| ret["size"] = adi.size | |
| ret["size"] = Int64(adi.size) |
Converting UInt64 to Int64 here prevents TOML.jl from writing the number in hex.
Member
Author
There was a problem hiding this comment.
Darn, I was hoping it would just call string(x), but I guess not. I'll just make everything an Int64 then.
staticfloat
force-pushed
the
sf/artifact_size
branch
from
4f582d1 to
947190c
Compare
This shows one possible way of adding an optional download size value to an artifact binding. While this value is not used anywhere yet, it could be used to create warnings when downloading large artifacts, or to feed progress meters when the server does not provide content size headers.
staticfloat
force-pushed
the
sf/artifact_size
branch
from
947190c to
355ddef
Compare
nhz2
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows one possible way of adding an optional download size value to an artifact binding. While this value is not used anywhere yet, it could be used to create warnings when downloading large artifacts, or to feed progress meters when the server does not provide content size headers.