Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

fix #5904, assertion failure running pipelines

must be careful using functional constructs where side effects are needed
  • Loading branch information...
commit b7063994cfe8c5e5950f56f026ff5bcbdb1d7d86 1 parent ca73d0d
@JeffBezanson JeffBezanson authored
Showing with 5 additions and 1 deletion.
  1. +1 −1  base/process.jl
  2. +4 −0 test/spawn.jl
View
2  base/process.jl
@@ -480,7 +480,7 @@ function success(x::Process)
kill(x)
test_success(x)
end
-success(procs::Vector{Process}) = all(success, procs)
+success(procs::Vector{Process}) = mapreduce(success, &, procs)
success(procs::ProcessChain) = success(procs.processes)
success(cmd::AbstractCmd) = success(spawn(cmd))
View
4 test/spawn.jl
@@ -122,3 +122,7 @@ yield()
# issue #4535
exename=joinpath(JULIA_HOME,(ccall(:jl_is_debugbuild,Cint,())==0?"julia-basic":"julia-debug-basic"))
@test readall(`$exename -f -e 'println(STDERR,"Hello World")'` .> `cat`) == "Hello World\n"
+
+
+# issue #5904
+@test run(ignorestatus(`false`) |> `true`) === nothing

1 comment on commit b706399

@StefanKarpinski

Yikes. That's rather unfortunate.

Please sign in to comment.
Something went wrong with that request. Please try again.