Permalink
Browse files

Pkg: pull requests no longer take '?expand=1'

This used to open up to the pull request but no longer does. Now it's better to just show the user the diff and let them click the "create pull request" button on that page.
  • Loading branch information...
1 parent c776e53 commit b808af48d1e86cf84731402510c2c8754f98c2af @StefanKarpinski StefanKarpinski committed Mar 5, 2014
Showing with 1 addition and 1 deletion.
  1. +1 −1 base/pkg/entry.jl
View
@@ -292,7 +292,7 @@ function pull_request(dir::String, commit::String="", url::String="")
branch = "pull-request/$(commit[1:8])"
info("Pushing changes as branch $branch")
Git.run(`push -q $fork $commit:refs/heads/$branch`, dir=dir)
- pr_url = "$(response["html_url"])/compare/$branch?expand=1"
+ pr_url = "$(response["html_url"])/compare/$branch"
@osx? run(`open $pr_url`) : info("To create a pull-request open:\n\n $pr_url\n")
end

0 comments on commit b808af4

Please sign in to comment.