Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a base keyword to logspace #22310

Merged
merged 1 commit into from Jun 11, 2017
Merged

add a base keyword to logspace #22310

merged 1 commit into from Jun 11, 2017

Conversation

fredrikekre
Copy link
Member

Example:

julia> logspace(1, 4, 4, base=2)
4-element Array{Float64,1}:
  2.0
  4.0
  8.0
 16.0

julia> logspace(1, 3, 3, base=10)
3-element Array{Float64,1}:
   10.0
  100.0
 1000.0

(ref https://docs.scipy.org/doc/numpy/reference/generated/numpy.logspace.html)

@ararslan ararslan added the collections Data structures holding multiple items, e.g. sets label Jun 9, 2017
nalimilan
nalimilan reviewed Jun 10, 2017
View reviewed changes
NEWS.md Outdated
@@ -65,6 +65,9 @@ Library improvements
git repo. Additionally, the argument order was changed to be consistent with the git
command line tool ([#22062]).

* `logspace` now accepts a `base` keyword to specify the base of the logarithmic range.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"keyword argument"

@fredrikekre
add a base keyword to logspace
0b891b4 
to specify the base (which otherwise defaults to 10)
Sacha0
Sacha0 approved these changes Jun 11, 2017
View reviewed changes
Copy link
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superficially this lgtm! :)

@KristofferC KristofferC merged commit 85ef52c into JuliaLang:master Jun 11, 2017
@fredrikekre fredrikekre deleted the fe/logspace-base branch June 11, 2017 22:14
quinnj pushed a commit that referenced this pull request Jun 20, 2017
@fredrikekre @quinnj
add a base keyword to logspace (#22310)
d7aa63c 
to specify the base (which otherwise defaults to 10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan left review comments

@Sacha0 Sacha0 Sacha0 approved these changes

Assignees
No one assigned
Labels
collections Data structures holding multiple items, e.g. sets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fredrikekre @nalimilan @Sacha0 @KristofferC @ararslan