allow splatting in calls to new
#30577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll want to teach SROA about this also |
|
I hoped it would be enough to inline this to a normal |
|
Yeah, I guess that's ok for now. There's fancier things one could do of course, but maybe that's future work. |
JeffBezanson
force-pushed
the
jb/splatnew
branch
from
d81be12
to
10ebb97
Compare
JeffBezanson
changed the title
splatnew form; like new but accepts a tuplenew
JeffBezanson
force-pushed
the
jb/splatnew
branch
from
b45cfda
to
32de7f1
Compare
JeffBezanson
force-pushed
the
jb/splatnew
branch
4 times, most recently
from
d3729f9
to
c2cb02e
Compare
adds `splatnew` form; like `new` but accepts a tuple
JeffBezanson
force-pushed
the
jb/splatnew
branch
from
c2cb02e
to
e456a72
Compare
lcw
added a commit
to lcw/TypedTables.jl
that referenced
this pull request
Mar 19, 2019
The workaround for JuliaLang/julia#29970 causes newer versions of Julia to hang in the precompilation step for TypedTables. Since JuliaLang/julia#29970 has been addressed in JuliaLang/julia#30577 the code is avoided in newer versions of Julia.
chakravala
added a commit
to chakravala/julia
that referenced
this pull request
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the core NamedTuple constructor to be defined without generated functions.
With a bit of work in the front end it will also allow splatting insideDone!newin general, which is kind of a neat feature.Unfortunately this does not yet do much for named tuples of Unions, but it's heading in the right direction.