Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure due to MINSIGSTKSZ with glibc 2.33 #39822

Closed
nalimilan opened this issue Feb 25, 2021 · 3 comments
Closed

Build failure due to MINSIGSTKSZ with glibc 2.33 #39822

nalimilan opened this issue Feb 25, 2021 · 3 comments
Labels
build Build system, or building Julia or its dependencies

Comments

@nalimilan
Copy link
Member

nalimilan commented Feb 25, 2021

glibc 2.33 deprecated the MINSIGSTKSZ constant in favor of sysconf (_SC_MINSIGSTKSZ):
https://sourceware.org/git/?p=glibc.git;a=commit;h=6c57d320484988e87e446e2e60ce42816bf51d53

This makes the build fail on Fedora Rawhide due to these lines (both on 1.6.0-rc1 and master):

julia/src/task.c

Lines 67 to 73 in a12d0ff

// empirically, jl_finish_task needs about 64k stack space to infer/run
// and additionally, gc-stack reserves 64k for the guard pages
#if defined(MINSIGSTKSZ) && MINSIGSTKSZ > 131072
#define MINSTKSZ MINSIGSTKSZ
#else
#define MINSTKSZ 131072
#endif

make -j2
[...]
    CC src/task.o
In file included from /usr/include/signal.h:315,
                 from /home/fedora/nalimilan/julia/src/task.c:31:
/home/fedora/nalimilan/julia/src/task.c:69:29: error: missing binary operator before token "("
   69 | #if defined(MINSIGSTKSZ) && MINSIGSTKSZ > 131072
      |                             ^~~~~~~~~~~

FWIW, this only happens with -D_GNU_SOURCE, but AFAICT Julia needs it.

(See also https://bugzilla.redhat.com/show_bug.cgi?id=1928696.)

Cc: @vtjnash who touched these lines last.

@nalimilan nalimilan added the build Build system, or building Julia or its dependencies label Feb 25, 2021
@tpapp
Copy link
Contributor

tpapp commented Nov 2, 2021

I am getting this error on Ubuntu 21.10, is there a workaround?

@tpapp
Copy link
Contributor

tpapp commented Nov 2, 2021

I think that #41860 fixes this but it wasn't backported into release-1.7, which I was trying to compile.

@nalimilan
Copy link
Member Author

nalimilan commented Nov 2, 2021

Cool. #39822 has been marked for backport, so closing.

EDIT(vtjnash): that link should be to #41860, instead of linking this issue to itself

nandanvasudevan added a commit to nandanvasudevan/cppzmq that referenced this issue Jun 15, 2022
Fixes issue with MINSIGSTKSZ which is no longer a constant -> JuliaLang/julia#39822

Issue was fixed in https://github.com/catchorg/Catch2/releases/tag/v2.13.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system, or building Julia or its dependencies
Development

No branches or pull requests

2 participants