Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg.publish(): protection against non-pushed commits? #6555

Closed
timholy opened this issue Apr 17, 2014 · 2 comments
Closed

Pkg.publish(): protection against non-pushed commits? #6555

timholy opened this issue Apr 17, 2014 · 2 comments
Assignees
Labels
domain:packages Package management and loading

Comments

@timholy
Copy link
Sponsor Member

timholy commented Apr 17, 2014

I had the impression that publish guarded against registering sha1s that had not been pushed, but I just got this:

julia> Pkg.publish()
INFO: Validating METADATA
INFO: Pushing Grid permanent tags: v0.3.0
INFO: Submitting METADATA changes
INFO: Forking JuliaLang/METADATA.jl to timholy
INFO: Pushing changes as branch pull-request/e2af1570
INFO: To create a pull-request open:

  https://github.com/timholy/METADATA.jl/compare/pull-request/e2af1570

with this repository state:

tim@diva:~/.julia/v0.3/Grid$ git log --graph --abbrev-commit --pretty=oneline --decorate
* cd4c99d (HEAD, tag: v0.3.0, master) Fixes for elimination of solve! (fix #13)
* 061dc31 (origin/master, origin/HEAD) restrict/prolong: fix type declaration for non-BLAS types
* eb09710 (tag: v0.2.12) Allow `range` to work on older Julias
@ivarne
Copy link
Sponsor Member

ivarne commented Apr 17, 2014

We should also have something that makes it easier to review pull requests to METADATA for formal errors.

@jakebolewski
Copy link
Member

Moving to JuliaLang/PkgDev.jl#11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:packages Package management and loading
Projects
None yet
Development

No branches or pull requests

5 participants