Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: create Libc and Libdl modules #10328

Merged
merged 3 commits into from Mar 16, 2015

Conversation

4 participants
@JeffBezanson
Copy link
Member

commented Feb 25, 2015

This moves a lot of low-level Base exports inside Libc and Libdl modules.

Some things, like dlopen and dlsym, might be widely used in packages, in which case we can add deprecations.

I'd like to see more breaking-down of the Base exports list. Filesystem operations are another candidate.

TODO: Doc updates for this.

@JeffBezanson JeffBezanson force-pushed the jb/libc branch 2 times, most recently from 8725fdd to 67d3cd2 Mar 8, 2015

JeffBezanson added a commit that referenced this pull request Mar 16, 2015

Merge pull request #10328 from JuliaLang/jb/libc
RFC: create Libc and Libdl modules

@JeffBezanson JeffBezanson merged commit ba96a7b into master Mar 16, 2015

0 of 3 checks passed

continuous-integration/appveyor AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@tkelman

This comment has been minimized.

Copy link
Contributor

commented on base/file.jl in 074286c Mar 16, 2015

Libc.Errno.EEXIST, right?

This comment has been minimized.

Copy link
Member Author

replied Mar 16, 2015

Yes. We might want to get rid of the extra Errno module too and just put them in Libc.

This comment has been minimized.

Copy link
Contributor

replied Mar 16, 2015

It seems this is the only actual use case in base, judging by
cut -f2 -d' ' base/errno_h.jl | grep -w -n -f - -R base --exclude=errno.jl --exclude=errno_h.jl --exclude=uv_constants.jl - without -w it's only false matches from UV constants or things named DEFAULT.

This comment has been minimized.

Copy link
Member

replied Mar 16, 2015

@JeffBezanson do you want me to do a PR to get rid of Errno module? I'm looking to fix ZMQ pronto.

This comment has been minimized.

Copy link
Member Author

replied Mar 16, 2015

This comment has been minimized.

Copy link
Member

replied Mar 16, 2015

@tkelman

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2015

PkgEvaluator is going to have a field day with this one, since it breaks BinDeps. Working on a fix, somebody say so if you're further along than I am.

tkelman added a commit to JuliaPackaging/BinDeps.jl that referenced this pull request Mar 16, 2015

Fix for JuliaLang/julia#10328
Libdl is now a separate module
@IainNZ

This comment has been minimized.

Copy link
Member

commented Mar 16, 2015

tkelman added a commit to JuliaPackaging/BinDeps.jl that referenced this pull request Mar 16, 2015

Fix for JuliaLang/julia#10328
Libdl is now a separate module

simonster added a commit to simonster/PyCall.jl that referenced this pull request Mar 17, 2015

@JeffBezanson JeffBezanson deleted the jb/libc branch Mar 18, 2015

stevengj added a commit to JuliaPy/PyCall.jl that referenced this pull request Mar 18, 2015

@sjkelly sjkelly referenced this pull request Mar 23, 2015

Merged

Feature/tweak testing #38

kdesysadmin pushed a commit to KDE/cantor that referenced this pull request Apr 26, 2018

Improve Julia cmake build system
Summary: Update `FindJulia.cmake` according new version of [this](https://gist.github.com/JayKickliter/06d0e7c4f84ef7ccc7a9), add small change (change `Sys` to `Libdl` accroding [this](JuliaLang/julia#10328)) and add checking of existing dev files of julia, because you can have julia, but haven't include files. Also fix some problems in `juliabackends` cmake files, related with case sensivity of cmake variables.

Reviewers: #cantor, asemke

Reviewed By: #cantor, asemke

Subscribers: #cantor, #kde_edu

Tags: #kde_edu, #cantor

Differential Revision: https://phabricator.kde.org/D12121

kdesysadmin pushed a commit to KDE/cantor that referenced this pull request May 7, 2018

Improve Julia cmake build system
Summary: Update `FindJulia.cmake` according new version of [this](https://gist.github.com/JayKickliter/06d0e7c4f84ef7ccc7a9), add small change (change `Sys` to `Libdl` accroding [this](JuliaLang/julia#10328)) and add checking of existing dev files of julia, because you can have julia, but haven't include files. Also fix some problems in `juliabackends` cmake files, related with case sensivity of cmake variables.

Reviewers: #cantor, asemke

Reviewed By: #cantor, asemke

Subscribers: #cantor, #kde_edu

Tags: #kde_edu, #cantor

Differential Revision: https://phabricator.kde.org/D12121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.