Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build in the multiarch directories as well #13163

Merged
merged 2 commits into from Sep 18, 2015
Merged

Build in the multiarch directories as well #13163

merged 2 commits into from Sep 18, 2015

Conversation

ginggs
Copy link
Contributor

@ginggs ginggs commented Sep 16, 2015

This makes $(private_libdir_rel) = $(build_private_libdir_rel), so that patchelf is no longer required (on Debian, at least)

@ginggs
Build in the multiarch directories as well
5726979 
This makes $(private_libdir_rel) = $(build_private_libdir_rel), so that patchelf is no longer required (on Debian, at least)
@tkelman
Copy link
Contributor

tkelman commented Sep 16, 2015

Hm, this originated in #1565. @staticfloat is this okay, does this option get used anywhere beyond the PPA and/or the debian package?

Recently the makefiles were revamped to prefer using := instead of =, should probably follow that here.

@nalimilan
Copy link
Member

It would be even better to define private_libdir := $(libdir)/julia and build_private_libdir := $(build_libdir)/julia.

@staticfloat
Copy link
Sponsor Member

Yes this looks fine. Milan's suggestion is a good one, in the event that
the user overrides libdir.

On Wed, Sep 16, 2015, 6:01 AM Milan Bouchet-Valat notifications@github.com
wrote:

It would be even better to define private_libdir := $(libdir)/julia and build_private_libdir
:= $(build_libdir)/julia.

—
Reply to this email directly or view it on GitHub
#13163 (comment).

@ginggs
Copy link
Contributor Author

ginggs commented Sep 17, 2015

Thanks for the comments. Looking at this again, since the change from = to :=, the whole # This is used for debian packaging... section should probably go above the # Calculate relative paths... section.

staticfloat added a commit that referenced this pull request Sep 18, 2015
@staticfloat
Merge pull request #13163 from ginggs/patch-1
ef833f0 
Build in the multiarch directories as well
@staticfloat staticfloat merged commit ef833f0 into JuliaLang:master Sep 18, 2015
@staticfloat
Copy link
Sponsor Member

Looks good to me! Thanks @ginggs!

@ViralBShah ViralBShah added build Build system, or building Julia or its dependencies backport pending 0.4 labels Sep 19, 2015
tkelman pushed a commit that referenced this pull request Sep 20, 2015
@ginggs @tkelman
Build in the multiarch directories as well
063ea24 
This makes $(private_libdir_rel) = $(build_private_libdir_rel), so that patchelf is no longer required (on Debian, at least)
(cherry picked from commit 5726979)
ref #13163
@tkelman
Copy link
Contributor

tkelman commented Sep 20, 2015

backported (though without the :=) in 063ea24 and 062a9e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Build system, or building Julia or its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ginggs @tkelman @nalimilan @staticfloat @ViralBShah