New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small optimisation in matrix norm #1326
Conversation
When I do a "make testall" with this, I get a failure in Rmath:
assertion failed: :( (xy<tolerance) ) Does it pass for you? |
I am getting that Rmath failure too. Need to figure out why. I wonder what in the lapack code affects the Rmath stuff. @dmbates may have a hunch. |
Small optimisation in matrix norm
I am not into what is going on in the tests but the failure is unrelated to my change. It fails in the old version as well. It is weird because when I do make Rmath in the test directory it passes. |
It worked for me in master. I wonder if we have another case of intermittent failure due to rand()? |
This is not due to rand. It started happening for me after the lapack reorganization in vs/linalg, and before my rand related changes were in. It is also not intermittent. -viral On 02-Oct-2012, at 4:13 PM, Tim Holy wrote:
|
As I indicated in #1324 it appears that the failure results from the state of the random number generator when it enters the script test/Rmath.jl. It happens to generate a random negative binomial value that is an extreme value in the distribution. I suggest initializing the random number generator in the test script. |
...the vectors