Fix inlinedAt debug locations #13431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a range from "backport this right away and run pkgeval on it, delaying rc4 for it" to "wait for 0.4.1," where does this sit? |
|
it's somewhat (sometimes highly) annoying to have line numbers reported incorrectly from error, but i'm not sure it is critical |
|
I'd say wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores correct(*) inlined code location annotations from #12544. After 35c5234,
ctx.linenocannot be used to indicate the function starting location, so hold this in a local variable instead.*(still need a way to handle nested inlines for the full solution)