julia-mode: Indent manually inside multi-line strings #15183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get an error |
|
That's odd, because it's already used here |
|
Oh never mind, I see that it's just the order. Ok I'll fix it now |
Don't try to automatically indent when inside strings with newline characters. We don't want to add indentation where it is not intended, so any automatic formatting should not assume that we want to indent inside a string. This also fixes JuliaLang#12419, because we won't get confused by keywords in multi-line strings. Because it is still useful, make TAB and <backtab> increase and decrease indentation when called inside a string.
justbur
force-pushed
the
julia-mode-indent-strings
branch
from
3f5de57
to
63087c5
Compare
|
fixed |
|
Local test passes and the change (with comment) makes sense. This is great! Finally don't need to avoid using certain keywords in doc string or put a few p.s. Looks like there's some issue with llvm on travis lin64? llvm is complaining about not finding the right versioned symbol in libstdc++... |
yuyichao
added a commit
that referenced
this pull request
Feb 23, 2016
julia-mode: Indent manually inside multi-line strings
apt-get failure to get recent gcc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to automatically indent when inside strings with newline
characters. We don't want to add indentation where it is not intended,
so any automatic formatting should not assume that we want to indent
inside a string. This also fixes #12419, because we won't get confused
by keywords in multi-line strings.
Because it is still useful, make TAB and increase and decrease
indentation when called inside a string.