Add macro to simplify libgit2 type constructor definitions #19473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I also changed a couple of fields from |
ararslan
reviewed
Dec 1, 2016
base/libgit2/types.jl
Outdated
| """ | ||
| @kwdef typedef | ||
| This is a helper macro that automatically defines a keyword-based constructor for the type declared in the expression `typedef`, which must be a `type` or `immutable` expression. The default argument is supplied by declaring fields of the form `field::Type = default`. If no default is provided then the default is: |
Member
There was a problem hiding this comment.
Perhaps this should be broken onto multiple lines?
simonbyrne
force-pushed
the
sb/libgit2-kw
branch
from
f4be7d8 to
284e9f7
Compare
Contributor
|
This should probably be in util.jl or something since it's not really libgit2 specific. |
simonbyrne
force-pushed
the
sb/libgit2-kw
branch
from
284e9f7 to
a191ec3
Compare
Member
|
I like this idea. We should probably have language features for this kind of thing eventually. |
Member
|
If we're going to have it be more general and user-facing, we might want to make the name a little more specific. I don't have a better suggestion though... |
Member
Author
|
I've moved it, open to better suggestions on names. |
This adds a macro that automatically defines a keyword argument only constructor for a type declaration.
up a few pointer conversions.
simonbyrne
force-pushed
the
sb/libgit2-kw
branch
from
079724c to
fb16580
Compare
tkelman
reviewed
Dec 8, 2016
| immutable RebaseOptions | ||
| version::Cuint | ||
| quiet::Cint | ||
| Matches the `git_rebase_options` struct. |
Member
Author
There was a problem hiding this comment.
No, their HTML docs are a bit incomplete.
Member
Author
|
Any more thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a macro that automatically defines a keyword argument only constructor for a type declaration.