move crc32c to stdlib #24489
Merged
move crc32c to stdlib #24489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Nov 6, 2017
base/deprecated.jl
Outdated
| @deprecate_moved watch_file "FileWatching" true true | ||
| @deprecate_moved FileMonitor "FileWatching" true true | ||
|
|
||
| @deprecate_moved crc32c "CRC32C" true true |
Member
There was a problem hiding this comment.
Later on you don't capitalize the last letter in "CRC32c"?
stevengj
approved these changes
Nov 6, 2017
stevengj
approved these changes
Nov 6, 2017
musm
reviewed
Nov 6, 2017
| crc32c_sw(s::String, crc::UInt32=0x00000000) = unsafe_crc32c_sw(s, sizeof(s), crc) | ||
| function crc32c_sw(io::IO, nb::Integer, crc::UInt32=0x00000000) | ||
| nb < 0 && throw(ArgumentError("number of bytes to checksum must be ≥ 0")) | ||
| buf = Array{UInt8}(min(nb, 24576)) |
Contributor
There was a problem hiding this comment.
Unrelated but maybe you can change this to a Vector
Member
There was a problem hiding this comment.
It is a vector already. Not sure why you object to the Array{T}(n) constructor, which is documented and type-stable.
Contributor
There was a problem hiding this comment.
I thought it should help the reduce runtime cost if we explicitly specify it as a one-dimensional array
Contributor
There was a problem hiding this comment.
No it does not reduce any runtime cost. It's only recommended for clarity and minor type inference performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24235
CC @stevengj, @StefanKarpinski