Skip to content

Conversation

@ararslan
Copy link
Member

@ararslan ararslan commented Feb 1, 2018

This reverts commit fe2d49f.

The change in #22253 essentially broke the round-trippable-ness of using at-show with arrays. It was decided that the change should simply be reverted.

Fixes #25848.

@ararslan ararslan added this to the 1.0 milestone Feb 1, 2018
@StefanKarpinski
Copy link
Member

Probably best to change the test rather than revert that part.

@matthieugomez
Copy link
Contributor

Could we use this definition for a macro called @display then?

This reverts commit fe2d49f.

The change in #22253 essentially broke the round-trippable-ness of using
`at-show` with arrays. It was decided that the change should simply be
reverted.
@ararslan ararslan force-pushed the aa/revert-multiline-show branch from 2f441e6 to 1768476 Compare February 1, 2018 21:42
@ararslan ararslan closed this Feb 2, 2018
@ararslan ararslan reopened this Feb 2, 2018
@JeffBezanson JeffBezanson merged commit 00fc299 into master Feb 2, 2018
@JeffBezanson JeffBezanson deleted the aa/revert-multiline-show branch February 2, 2018 17:58
@knuesel knuesel mentioned this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants