Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use multi-line format in at-show (#22253)" #25849

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Feb 1, 2018

This reverts commit fe2d49f.

The change in #22253 essentially broke the round-trippable-ness of using at-show with arrays. It was decided that the change should simply be reverted.

Fixes #25848.

@ararslan ararslan added this to the 1.0 milestone Feb 1, 2018
@StefanKarpinski
Copy link
Sponsor Member

Probably best to change the test rather than revert that part.

@matthieugomez
Copy link
Contributor

Could we use this definition for a macro called @display then?

This reverts commit fe2d49f.

The change in #22253 essentially broke the round-trippable-ness of using
`at-show` with arrays. It was decided that the change should simply be
reverted.
@ararslan ararslan closed this Feb 2, 2018
@ararslan ararslan reopened this Feb 2, 2018
@JeffBezanson JeffBezanson merged commit 00fc299 into master Feb 2, 2018
@JeffBezanson JeffBezanson deleted the aa/revert-multiline-show branch February 2, 2018 17:58
@knuesel knuesel mentioned this pull request May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants