fix #2648 #2657

Merged
merged 1 commit into from Mar 24, 2013

Projects

None yet

3 participants

@wlbksy
The Julia Language member

This fix #2648
Also request a pull in OpenBLAS to fix LAPACK download with wget

@ViralBShah
The Julia Language member

Seems like WGET_DASH_O should be defined in Make.inc, so that it is available in the top-level Makefile as well. This patch seems fine to me, but given that it touches all the build stuff in deps, I'd like to have others take a look at it as well.

@wlbksy Have you cloned a fresh julia using this and built it successfully?

@wlbksy
The Julia Language member

@ViralBShah ,
I have checked it and build one on my Win7 32-bit, see the 7th post of https://groups.google.com/forum/?fromgroups=#!topic/julia-dev/oqr1TEwpZR8 .

@ViralBShah
The Julia Language member

Ok. Let's leave this open for another day or so.

@wlbksy
The Julia Language member

Fair enough.
Still, due to openblas use wget to download LAPACK, I have pulled one there. Before @xianyi fix that , users should manually fix openblas' makefile if they meet wget problems

@vtjnash
The Julia Language member

looks fine to me. note that WGET and WGET_DASH_O both expand identically to the deps/jldownload script

the win-extras target in Makefile is only intended for use by packagers (me), as pseudo-documentation of the urls for the extra files needed in the distribution. It doesn't need to be complicated or particularly robost (it probably doesn't even work right)

@ViralBShah ViralBShah merged commit fb647a3 into JuliaLang:master Mar 24, 2013

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment