Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one(::CartesianIndex) => oneunit(::CartesianIndex) #29442

Merged
merged 2 commits into from Oct 5, 2018

Conversation

4 participants
@timholy
Copy link
Member

commented Sep 30, 2018

Ideally we should deprecate one(::CartesianIndex), but I am uncertain about the strategy for deprecations in 1.x. I tried to set it up so that it will be easy to do when the time comes, but I can change this given feedback.

@timholy

This comment has been minimized.

Copy link
Member Author

commented Sep 30, 2018

xref #26284

@Sacha0

Sacha0 approved these changes Sep 30, 2018

Copy link
Member

left a comment

Looks great! Thanks @timholy! :)

@JeffBezanson JeffBezanson added this to the 1.1 milestone Oct 2, 2018

@JeffBezanson

This comment has been minimized.

Copy link
Member

commented Oct 2, 2018

I think this is a good approach to deprecations for now.

@timholy timholy force-pushed the teh/oneunit_cartindex branch from 25ebb98 to 27a45f5 Oct 4, 2018

@timholy timholy removed the needs news label Oct 4, 2018

@timholy

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2018

I put the NEWS in the "deprecated" section even though there is no depwarn for now.

If there are no objections I'll merge soon.

@timholy timholy merged commit 50c27fd into master Oct 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@timholy timholy deleted the teh/oneunit_cartindex branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.