Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LinearAlgebra] Add isdiag/isposdef for Diagonal and UniformScaling #29638

merged 10 commits into from Oct 16, 2018

correct isposdef(::UniformScaling)

  • Loading branch information...
dkarrasch committed Oct 15, 2018
commit b53c3a5e6a93286d3ae3039780e617c24340cfc7
@@ -79,7 +79,7 @@ istriu(::UniformScaling) = true
istril(::UniformScaling) = true
issymmetric(::UniformScaling) = true
ishermitian(J::UniformScaling) = isreal(J.λ)
isposdef(J::UniformScaling) = J.λ > zero(J.λ)
isposdef(J::UniformScaling) = isposdef(J.λ)

(+)(J::UniformScaling, x::Number) = J.λ + x
(+)(x::Number, J::UniformScaling) = x + J.λ
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.