Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rtol and atol for pinv and nullspace #29998

Merged
merged 12 commits into from Dec 11, 2018

Conversation

5 participants
@sam0410
Copy link
Contributor

commented Nov 11, 2018

This is as discussed in the PR #29926

sam0410 added some commits Nov 10, 2018

@andyferris
Copy link
Contributor

left a comment

I like this idea!

Show resolved Hide resolved stdlib/LinearAlgebra/src/dense.jl Outdated
Show resolved Hide resolved stdlib/LinearAlgebra/src/dense.jl Outdated

sam0410 added some commits Nov 20, 2018

sam0410

@sam0410 sam0410 changed the title Adding rtol and atol for pinv and nullspace Adding rtol and atol for pinv and nullspace [WIP] Nov 21, 2018

@sam0410

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2018

Hi @andyferris, Sorry for the delay. I resolved your comment. Also there is some issue with the test/pinv tests. I will resolve them soon.

sam0410 added some commits Nov 22, 2018

sam0410
sam0410

@sam0410 sam0410 changed the title Adding rtol and atol for pinv and nullspace [WIP] Adding rtol and atol for pinv and nullspace Nov 23, 2018

@sam0410

This comment has been minimized.

Copy link
Contributor Author

commented Nov 23, 2018

Hi @andyferris, can you please review this PR now?
Thank you.

@simonbyrne

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2018

@sam0410 any chance you could update this along the lines of #29926? Also, add a NEWS.md item.

sam0410 added some commits Dec 7, 2018

sam0410
@sam0410

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

Hi @simonbyrne, I made the changes.
Thanks.

@sam0410

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

Oh ! Sorry, I didn't make that part clear.

@simonbyrne

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2018

No problem, I figured it was easier for me to make the changes than keep asking you for them. Thanks!

sam0410 and others added some commits Dec 10, 2018

typo from diff
[skip ci]

@simonbyrne simonbyrne merged commit 5b2e3e7 into JuliaLang:master Dec 11, 2018

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@simonbyrne

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2018

This can be backported to 1.1 since it also contains the NEWS item for #29926.

@sam0410 sam0410 deleted the sam0410:pinvNull branch Dec 11, 2018

KristofferC added a commit that referenced this pull request Dec 12, 2018

Adding rtol and atol for pinv and nullspace (#29998)
* Add code for rtol and atol

* add tests

* resolve comment

* fix typo

* fix tests

* add news.md item

* Not deprecated yet.

* Tweak docs slightly

* typo from diff

[skip ci]

(cherry picked from commit 5b2e3e7)

@KristofferC KristofferC referenced this pull request Dec 12, 2018

Merged

Backports for 1.1.0 #30309

45 of 52 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.