Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a hook in base for disabling threading #30004

Merged
merged 1 commit into from Dec 7, 2018

Conversation

6 participants
@fredrikekre
Copy link
Member

commented Nov 12, 2018

Implement a hook in base for disabling threading of libraries, use it to decouple Distributed from LinearAlgebra.

Alternative to #29975, WIP because I don't know if this is the interface we want, where the code should live, and what the names of the functions should be. Maybe not very important since these are all internal functions.

@fredrikekre fredrikekre added the stdlib label Nov 12, 2018

@fredrikekre fredrikekre force-pushed the fe/threading_hook branch from d092f92 to edffb57 Nov 12, 2018

@fredrikekre

This comment has been minimized.

Copy link
Member Author

commented Nov 12, 2018

Ah, this is basically #25951 (comment)

@fredrikekre

This comment has been minimized.

Copy link
Member Author

commented Dec 4, 2018

Bump for Julia 1.1

@KristofferC KristofferC added the triage label Dec 4, 2018

Show resolved Hide resolved base/initdefs.jl Outdated
@StefanKarpinski

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

Triage is in favor if you want to get this passing CI and merge it. Wants a NEWS entry too, right?

@StefanKarpinski StefanKarpinski removed the triage label Dec 6, 2018

@StefanKarpinski StefanKarpinski added this to the 1.1 milestone Dec 6, 2018

@fredrikekre fredrikekre force-pushed the fe/threading_hook branch from edffb57 to 1609b85 Dec 6, 2018

Implement a hook in base for disabling threading
of libraries, use it to decouple Distributed from LinearAlgebra.

@fredrikekre fredrikekre force-pushed the fe/threading_hook branch from 1609b85 to 7b48911 Dec 6, 2018

@fredrikekre fredrikekre changed the title [WIP] Implement a hook in base for disabling threading Implement a hook in base for disabling threading Dec 6, 2018

@fredrikekre

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2018

Great, updated. The last CI runs was during some flaky times IIRC, so I don't think there was something wrong with the PR.

@JeffBezanson JeffBezanson merged commit 5509306 into master Dec 7, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
julia freebsd ci Build done
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JeffBezanson JeffBezanson deleted the fe/threading_hook branch Dec 7, 2018

@ararslan

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

This seems to be causing the Distributed tests to fail on PkgEval:

ERROR: LoadError: On worker 2:
ArgumentError: Package LinearAlgebra not found in current path:
- Run `import Pkg; Pkg.add("LinearAlgebra")` to install the LinearAlgebra package.
@fredrikekre

This comment has been minimized.

Copy link
Member Author

commented Dec 8, 2018

#30311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.