Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`get(A::AbstractArray, (), default)` should get `A[]` #30270

Merged
merged 3 commits into from Dec 7, 2018

Conversation

4 participants
@mbauman
Copy link
Member

commented Dec 4, 2018

... and not allocate a new 0-element vector. I'm guessing few folks have ever looked at this method (besides to targetedly improve coverage) after it was implemented back in 2013, let alone use it. This is a breaking change that we should decide on.

I'm guessing you're not using this @timholy? (5994263)

`get(A::AbstractArray, (), default)` should get `A[]`
... and not allocate a new 0-element vector.
@timholy

This comment has been minimized.

Copy link
Member

commented Dec 4, 2018

I can't imagine why whatever moron wrote that 😉 had it return an array....

@JeffBezanson

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

Triage approves for 1.x.

@mbauman mbauman added this to the 1.1 milestone Dec 6, 2018

@mbauman mbauman removed the decision label Dec 6, 2018

@JeffBezanson JeffBezanson merged commit 1875947 into master Dec 7, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
julia freebsd ci Build done
Details

@JeffBezanson JeffBezanson deleted the mb/getwhatnow branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.