Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a function to extrema #30323

Merged
merged 1 commit into from Dec 14, 2018

Conversation

@ararslan
Copy link
Member

commented Dec 8, 2018

Currently minimum and maximum can accept a function argument, but extrema cannot. This makes it consistent.

I've set the !!! compat to Julia 1.1, but if this can't make it into the release then I can set it to 1.2 or whatever. Set to 1.2.

@ararslan ararslan requested a review from JeffBezanson Dec 8, 2018

@ararslan ararslan force-pushed the aa/extrema-function branch from 3e09b6b to 3088c9b Dec 9, 2018

@StefanKarpinski

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Marking for triage just to discuss whether we're allowing backports of new features past the 1.1 release branch date.

base/multidimensional.jl Outdated Show resolved Hide resolved

@ararslan ararslan force-pushed the aa/extrema-function branch from 3088c9b to a9356b6 Dec 10, 2018

@ararslan

This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2018

Test failures are from Pkg due to the current registry apocalypse

@StefanKarpinski

This comment has been minimized.

Copy link
Member

commented Dec 10, 2018

Should be better now.

@JeffBezanson

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

No, I don't think we should backport new features. IMO backporting after branch is only to fix release blockers.

@ararslan ararslan removed the triage label Dec 11, 2018

@ararslan ararslan force-pushed the aa/extrema-function branch from a9356b6 to 7fb1b46 Dec 11, 2018

Allow passing a function to extrema
Currently `minimum` and `maximum` can accept a function argument, but
`extrema` cannot. This makes it consistent.

@ararslan ararslan force-pushed the aa/extrema-function branch from 7fb1b46 to 3e2b0a5 Dec 13, 2018

@ararslan

This comment has been minimized.

Copy link
Member Author

commented Dec 14, 2018

32-bit Windows failure is the Profile thing.

@StefanKarpinski StefanKarpinski merged commit 01fe7c2 into master Dec 14, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
julia freebsd ci Build done
Details

@StefanKarpinski StefanKarpinski deleted the aa/extrema-function branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.