Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-Function args to retry #30382

Merged
merged 7 commits into from Feb 12, 2019

Conversation

@simonbyrne
Copy link
Contributor

commented Dec 13, 2018

I hit this while trying to use a PyObject

Allow non-Function args to retry
I hit this while trying to use a `PyObject`
@simonbyrne

This comment has been minimized.

Copy link
Contributor Author

commented Dec 13, 2018

@ararslan it should already be tested. Or is there a standard way for testing "works with a callable non-Function"?

@ararslan

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

I dunno, just try passing something that isn't a function (like e.g. a type) and see what happen?

@ararslan ararslan removed the needs news label Dec 13, 2018

simonbyrne added 2 commits Dec 14, 2018

@ararslan ararslan removed the needs tests label Dec 14, 2018

@fredrikekre

This comment has been minimized.

Copy link
Member

commented Dec 17, 2018

Add

!!! compat "Julia 1.2"
    Before Julia 1.2 this signature was restricted to `f::Function`.

before the examples in the docstring?

simonbyrne and others added 3 commits Dec 17, 2018

@simonbyrne simonbyrne merged commit 36d062d into master Feb 12, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
julia freebsd ci Build done
Details

@simonbyrne simonbyrne deleted the sb/retry branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.