Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libunwind to 1.3.1 #30724

Merged
merged 1 commit into from Jan 24, 2019

Conversation

@ararslan
Copy link
Member

commented Jan 15, 2019

This allows us to drop all of our patches except for one: the one that prefers extbl-based unwinding on ARM. It appears that patch will need to be redone atop current libunwind. @yuyichao, would you be able to help out with that, since you authored the original patch?

@ararslan

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

Elliot also mentioned that it would be good to know whether the patch is still necessary at all. Perhaps DWARF-based unwinding, which is the default for ARM in libunwind, is sufficient now.

@staticfloat

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

@yuyichao do you think that the old libunwind patch is still necessary?

@yuyichao

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

https://github.com/archlinuxcn/repo/tree/c97e87749097cdf7938e8f7f3dbcfa82f69c5e6c/archlinuxcn/libunwind-git

AFAIK nothing has changed about dwarf on arm. It's not what the platform use so there's just no reason to use it.

Update libunwind to 1.3.1
Co-authored-by: Yichao Yu <yyc1992@gmail.com>

@ararslan ararslan force-pushed the aa/libunwind-1.3.1 branch from b2e8ca0 to e2dc372 Jan 23, 2019

@ararslan

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

Perfect, thanks. I've updated the patch file with the contents of the Arch patch, modified to apply to libunwind 1.3.1. I've added Yichao as a co-author for the commit since the patch was his work.

@ararslan ararslan merged commit 0b0d2c6 into master Jan 24, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
julia freebsd ci Build done
Details

@ararslan ararslan deleted the aa/libunwind-1.3.1 branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.