Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JULIA_DEPOT_PATH: expand empty path to default #31009

Merged
merged 4 commits into from Feb 15, 2019

Conversation

@StefanKarpinski
Copy link
Member

commented Feb 8, 2019

This makes the behavior for JULIA_DEPOT_PATH expansion match that of
JULIA_LOAD_PATH expansion and allows one to manipulate the path
uncondionally with shell expressions like this:

export JULIA_DEPOT_PATH="$JULIA_DEPOT_PATH:/system/depot"

It also changes JULIA_LOAD_PATH expansion to do user name expansion just
like JULIA_DEPOT_PATH does, bringing the two variables into closer
behavioral agreement.

@StefanKarpinski

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2019

Implements #31002 on top of #31010.

base/initdefs.jl Outdated Show resolved Hide resolved
@JeffBezanson

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

Triage approves.

@JeffBezanson JeffBezanson removed the triage label Feb 14, 2019

StefanKarpinski and others added 3 commits Feb 8, 2019
JULIA_DEPOT_PATH: expand empty path to default
This makes the behavior for JULIA_DEPOT_PATH expansion match that
of JULIA_LOAD_PATH expansion and allows one to manipulate the path
uncondionally with shell expressions like this:

    export JULIA_DEPOT_PATH="$JULIA_DEPOT_PATH:/system/depot"

It also changes JULIA_LOAD_PATH expansion to do user name expansion
just like JULIA_DEPOT_PATH does, bringing the two variables into
closer behavioral agreement.

@fredrikekre fredrikekre force-pushed the sk/depot-path branch from 2f6dc22 to 0a9faeb Feb 14, 2019

@fredrikekre

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

Pushed some test cases and news.

@fredrikekre fredrikekre removed the needs news label Feb 14, 2019

@StefanKarpinski

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

Thank you, @fredrikekre! You are the best.

@fredrikekre fredrikekre merged commit 8b5ab23 into master Feb 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fredrikekre fredrikekre deleted the sk/depot-path branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.