Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a function to strip like rstrip and lstrip #31211

Merged
merged 1 commit into from Mar 4, 2019

Conversation

@ararslan
Copy link
Member

commented Feb 28, 2019

strip is documented to accept a function argument but it does not. rstrip and lstrip do, so it seems this was simply an oversight.

Fixes #31195.

NOTE: #31213 should be merged first!

@nalimilan

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

I'm not sure why but @simonbyrne didn't add that method in #27309 (comment).

@nalimilan nalimilan requested a review from simonbyrne Mar 1, 2019

@simonbyrne

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2019

I think it was an oversight as that PR got modified.

@@ -53,6 +53,7 @@ end
@test strip(" \u2009 hi \u2009 ") == "hi"
@test strip("foobarfoo", ['f','o']) == "bar"
@test strip("foobarfoo", ('f','o')) == "bar"
@test strip(ispunct, "¡Hola!") == "Hola"

This comment has been minimized.

Copy link
@StefanKarpinski

StefanKarpinski Mar 3, 2019

Member

❤️

Accept a function to strip like rstrip and lstrip
`strip` is documented to accept a function argument but it does not.
`rstrip` and `lstrip` do, so it seems this was simply an oversight.

See #31195.

@ararslan ararslan force-pushed the aa/strip-pred branch from e0e0d78 to 6b1fe72 Mar 3, 2019

@fredrikekre fredrikekre merged commit 79fd332 into master Mar 4, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
julia freebsd ci Build done
Details

@fredrikekre fredrikekre deleted the aa/strip-pred branch Mar 4, 2019

@sbromberger

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.