Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prefix argument to mktempdir #31230

Merged
merged 1 commit into from Mar 22, 2019

Conversation

@vtjnash
Copy link
Member

commented Mar 2, 2019

implements #22922
closes #23634, #13969

@maleadt

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

#13969 was about a fixed suffix, like a file extension.

@vtjnash

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

Ah thanks, I was too hasty in following links and trying to list related work

mktempdir: support user-defined prefix
Also switch to using libuv, as it now provides a platform-independent implementation.

Co-Authored-By: Jameson Nash <vtjnash@gmail.com>

@vtjnash vtjnash force-pushed the jn/sambitdash-I22922 branch from 8661f7e to 4226456 Mar 21, 2019

@vtjnash vtjnash merged commit a84970d into master Mar 22, 2019

11 of 15 checks passed

buildbot/package_freebsd64 Run complete
Details
buildbot/package_linuxaarch64 Run complete
Details
buildbot/package_linuxppc64le Run complete
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
buildbot/package_linux32 Run complete
Details
buildbot/package_linux64 Run complete
Details
buildbot/package_macos64 Run complete
Details
buildbot/package_win32 Run complete
Details
buildbot/package_win64 Run complete
Details
buildbot/tester_linux32 Run complete
Details
buildbot/tester_linux64 Run complete
Details
buildbot/tester_macos64 Run complete
Details
buildbot/tester_win32 Run complete
Details
buildbot/tester_win64 Run complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vtjnash vtjnash deleted the jn/sambitdash-I22922 branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.