Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filter for SkipMissing-wrapped arrays #31235

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@ararslan
Copy link
Member

commented Mar 2, 2019

See discussion in #31188. This makes filter(f, skipmissing(x)) eagerly return an array similar to the wrapped array but with missing values and !f(xi) elements removed.

NEWS.md Outdated Show resolved Hide resolved
@quinnj
quinnj approved these changes Mar 2, 2019

@ararslan ararslan force-pushed the aa/filter-skipmissing branch from 6b4394d to 96b3a39 Mar 2, 2019

@nalimilan
Copy link
Contributor

left a comment

Looks fine, but maybe this should go through triage?

base/missing.jl Outdated Show resolved Hide resolved
test/missing.jl Outdated Show resolved Hide resolved
test/missing.jl Outdated Show resolved Hide resolved
Support filter for SkipMissing-wrapped arrays
See discussion in issue 31188.

@ararslan ararslan force-pushed the aa/filter-skipmissing branch from 96b3a39 to ad218bc Mar 3, 2019

@ararslan ararslan requested a review from JeffBezanson Mar 5, 2019

@ararslan ararslan added the triage label Mar 7, 2019

@JeffBezanson JeffBezanson merged commit b3c0299 into master Mar 7, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
julia freebsd ci Build done
Details

@JeffBezanson JeffBezanson deleted the aa/filter-skipmissing branch Mar 7, 2019

@JeffBezanson JeffBezanson removed the triage label Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.