Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inv(::Missing) #31451

Merged
merged 2 commits into from Mar 26, 2019

Conversation

@narendrakpatel
Copy link
Contributor

commented Mar 22, 2019

Closes #31408

Adds inv(::Missing)
Adds test for inv(::Missing)

@@ -81,7 +81,7 @@ end
arithmetic_operators = [+, -, *, /, ^, Base.div, Base.mod, Base.fld, Base.rem]

# All unary operators return missing when evaluating missing
for f in [!, ~, +, -]
for f in [!, ~, +, -, inv]

This comment has been minimized.

Copy link
@nalimilan

nalimilan Mar 22, 2019

Contributor

Can you put with with elementary functions instead?

Also, please add an entry in NEWS.md.

This comment has been minimized.

Copy link
@narendrakpatel

narendrakpatel Mar 22, 2019

Author Contributor

About the compat annotation, Should I just add inv under unary operators in missing.md?

This comment has been minimized.

Copy link
@nalimilan

nalimilan Mar 24, 2019

Contributor

Sorry, I'm not sure what you mean. In NEWS.md, please add an entry under "New language features".

This comment has been minimized.

Copy link
@narendrakpatel

narendrakpatel Mar 24, 2019

Author Contributor

Please check the most recent commit. My query was regarding needs compat annotation label.

This comment has been minimized.

Copy link
@nalimilan

nalimilan Mar 24, 2019

Contributor

My query was regarding needs compat annotation label.

Ah, OK. I don't think it's appropriate since there's no docstring. @ararslan?

EDIT: I guess we could add a !!! compat "Julia 1.2" block to the inv docstring mentioning missing values.

This comment has been minimized.

Copy link
@ararslan

ararslan Mar 25, 2019

Member

Yes, it should be in the existing docstring for inv

@narendrakpatel narendrakpatel force-pushed the narendrakpatel:np/inv-missing branch from eba30f0 to a7a27d2 Mar 23, 2019

@narendrakpatel narendrakpatel force-pushed the narendrakpatel:np/inv-missing branch from a7a27d2 to 8285d78 Mar 24, 2019

@narendrakpatel

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

If this is okay, can this be merged? @ararslan

@ararslan ararslan merged commit 8649af9 into JuliaLang:master Mar 26, 2019

6 of 10 checks passed

buildbot/package_macos64 Run complete
Details
buildbot/package_freebsd64 Run complete
Details
buildbot/tester_linuxaarch64 Run complete
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
buildbot/package_linux32 Run complete
Details
buildbot/package_linux64 Run complete
Details
buildbot/package_linuxaarch64 Run complete
Details
buildbot/tester_linux32 Run complete
Details
buildbot/tester_linux64 Run complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.