Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vararg methods for mapreduce similar to map, fixes #27704. #31532

Merged
merged 1 commit into from Apr 3, 2019

Conversation

@fredrikekre
Copy link
Member

commented Mar 29, 2019

This is not really an optimal implementation, but I wanted to try to get the functionality in for 1.2. Should be fine to make improvements later.

@fredrikekre fredrikekre requested review from andyferris and mbauman Mar 29, 2019

@tkf

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

I think this can be optimized by lowering to Broadcasted-based mapreduce in #31020 in the future. That is to say, mapreduce(f, op, x, y, z) can call whatever mapreduce(identity, op, Broadcast.instantiate(Broadcast.broadcasted(f, x, y, z)))) would call internally.

@fredrikekre fredrikekre force-pushed the fe/multi-arg-mapreduce branch from b739916 to 052d276 Apr 3, 2019

@fredrikekre fredrikekre force-pushed the fe/multi-arg-mapreduce branch from 052d276 to 48fd53d Apr 3, 2019

@fredrikekre

This comment has been minimized.

Copy link
Member Author

commented Apr 3, 2019

bump

@StefanKarpinski

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

@mbauman: do you think you could review so that this can make it into 1.2?

@mbauman mbauman merged commit a24c38c into master Apr 3, 2019

12 of 14 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
buildbot/package_freebsd64 Run complete
Details
buildbot/package_linux32 Run complete
Details
buildbot/package_linux64 Run complete
Details
buildbot/package_macos64 Run complete
Details
buildbot/package_win32 Run complete
Details
buildbot/package_win64 Run complete
Details
buildbot/tester_freebsd64 Run complete
Details
buildbot/tester_linux32 Run complete
Details
buildbot/tester_linux64 Run complete
Details
buildbot/tester_macos64 Run complete
Details
buildbot/tester_win32 Run complete
Details
buildbot/tester_win64 Run complete
Details

@mbauman mbauman deleted the fe/multi-arg-mapreduce branch Apr 3, 2019

@mbauman

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

LGTM! Thanks @fredrikekre.

@sdaxen sdaxen referenced this pull request Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.