Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export nonmissingtype #31562

Closed
wants to merge 1 commit into from
Closed

Export nonmissingtype #31562

wants to merge 1 commit into from

Conversation

@juliohm
Copy link
Contributor

juliohm commented Mar 30, 2019

Fix #30657

Fix #30657
@juliohm

This comment has been minimized.

Copy link
Contributor Author

juliohm commented Apr 4, 2019

I don't have time at the moment to work on this. Please feel free to improve the PR.

@nalimilan nalimilan mentioned this pull request Jun 14, 2019
@juliohm

This comment has been minimized.

Copy link
Contributor Author

juliohm commented Jul 27, 2019

Can this be merged into Julia 1.2 or Julia 1.3?

@vtjnash

This comment has been minimized.

Copy link
Member

vtjnash commented Aug 8, 2019

Perhaps should wait for #31602?

@StefanKarpinski

This comment has been minimized.

Copy link
Member

StefanKarpinski commented Aug 8, 2019

Too late for 1.2, can go into 1.3. As long as #31602 also goes into 1.3, this is fine 👍

@StefanKarpinski StefanKarpinski removed the triage label Aug 8, 2019
@StefanKarpinski StefanKarpinski added this to the 1.3 milestone Aug 8, 2019
@JeffBezanson

This comment has been minimized.

Copy link
Member

JeffBezanson commented Aug 8, 2019

From #31602, there is a question on whether this should check to make sure it could do anything; e.g. nonmissingtype(Any) == Any, which might violate your assumptions.

Mostly this needs docs though.

@StefanKarpinski

This comment has been minimized.

Copy link
Member

StefanKarpinski commented Aug 8, 2019

What about calling this subtract_missing to match Base.subtract_singletontype?

@JeffBezanson

This comment has been minimized.

Copy link
Member

JeffBezanson commented Aug 8, 2019

Thank goodness subtract_singletontype isn't exported :) That is a pretty rancid name/concept.

@StefanKarpinski

This comment has been minimized.

Copy link
Member

StefanKarpinski commented Aug 8, 2019

I find subtractmissing to be a clearer name for what this does than nonmissingtype which seems like it might be an assertion or something? I would have no immediate guess about what a function by that name would do. The name subtractmissing at least gives me a hint.

@juliohm

This comment has been minimized.

Copy link
Contributor Author

juliohm commented Aug 10, 2019

I personally find subtractmissing confusing. It may read well for core developers, but end users will ask why "subtraction"? I'd even shorten the name further and write nonmissing. The "type" suffix is intuitive from the call? nonmissing(T)

@JeffBezanson

This comment has been minimized.

Copy link
Member

JeffBezanson commented Aug 15, 2019

Please add docs and news, then triage is ok with the name nonmissingtype.

@juliohm

This comment has been minimized.

Copy link
Contributor Author

juliohm commented Aug 15, 2019

@JeffBezanson

This comment has been minimized.

Copy link
Member

JeffBezanson commented Aug 15, 2019

Docs added and merged.

JeffBezanson added a commit that referenced this pull request Aug 15, 2019
dkarrasch added a commit to dkarrasch/julia that referenced this pull request Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.