Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

threads,win64: fix safepoint handler #32570

Merged
merged 1 commit into from Jul 14, 2019

Conversation

@vtjnash
Copy link
Member

commented Jul 12, 2019

On Win64, we need the top stack frame to have a personality
to catch exceptions in the event that we run into a GC safepoint
(such as jl_mutex_wait) before we have Julia code on the stack.

threads,win64: fix safepoint handler
On Win64, we need the top stack frame to have a personality
to catch exceptions in the event that we run into a GC safepoint
(such as jl_mutex_wait) before we have Julia code on the stack.
@JeffBezanson

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Fixes the win64 failure in #32477. 🎉

@ararslan ararslan added the windows label Jul 12, 2019

@JeffBezanson JeffBezanson merged commit a1165b8 into master Jul 14, 2019

18 checks passed

buildbot/analyzegc_linux64 Run complete
Details
buildbot/doctest_linux64 Run complete
Details
buildbot/llvmpasses_linux64 Run complete
Details
buildbot/package_freebsd64 Run complete
Details
buildbot/package_linux32 Run complete
Details
buildbot/package_linux64 Run complete
Details
buildbot/package_macos64 Run complete
Details
buildbot/package_win32 Run complete
Details
buildbot/package_win64 Run complete
Details
buildbot/tester_freebsd64 Run complete
Details
buildbot/tester_linux32 Run complete
Details
buildbot/tester_linux64 Run complete
Details
buildbot/tester_macos64 Run complete
Details
buildbot/tester_win32 Run complete
Details
buildbot/tester_win64 Run complete
Details
buildbot/whitespace_linux32 Run complete
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@JeffBezanson JeffBezanson deleted the jn/win64-segv-handle branch Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.