Allow indexing of SparseMatrixCSC by array of CartesianIndex
#33225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Sep 12, 2019
stevengj
reviewed
Sep 12, 2019
stevengj
approved these changes
Sep 12, 2019
Contributor
Author
|
@stevengj The tests seem to fail because of the most recent change. I've scrolled through it and saw that it has something to do with ambiguities... Do you know how to resolve this? I will look at it as soon as I have some time... |
Member
|
It looks like the ambiguity will be fixed if you just define: Base._ind2sub(t::AbstractArray, ind::CartesianIndex) = Tuple(ind)instead of |
Contributor
Author
|
Thank you @stevengj, I've finally changed it to Base._ind2sub(t::Tuple, ind::CartesianIndex) = Tuple(ind)It seems to pass the test now (I think the failed test for |
Member
|
LGTM. |
Member
|
Thanks, @goggle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix #30981.
I'm not sure if using these nested function definitions
_rowcolis the right way to do it. If not, let me know what I should do instead.