Add broadcasting examples to in and ∉ docstrings.
#35023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Mar 5, 2020
nalimilan
reviewed
Mar 6, 2020
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Contributor
Author
|
Ok, I've added a more detailed explanation to the docs, as requested by @stevengj and @nalimilan . I think this PR might be ready to be merged now. |
stevengj
approved these changes
Mar 11, 2020
nalimilan
approved these changes
Mar 23, 2020
oxinabox
pushed a commit
to oxinabox/julia
that referenced
this pull request
Apr 8, 2020
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
ravibitsgoa
pushed a commit
to ravibitsgoa/julia
that referenced
this pull request
Apr 9, 2020
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds examples to the
inand∉docstrings that show how to use those infix operators in broadcasting expressions where the collection on the right side is intended to be treated as scalar. I've included one example with the right side enclosed in a tuple and one without the tuple to demonstrate the difference between the two, since the latter is also valid syntax that could easily be confused with the right-side-as-a-scalar behavior.