Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support missing in radians-degrees conversions #35142

Closed
wants to merge 2 commits into from
Closed

support missing in radians-degrees conversions #35142

wants to merge 2 commits into from

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Mar 17, 2020

No description provided.

Copy link
Sponsor Member

@KristofferC KristofferC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#35066 probably needs to be discussed first

@aplavin
Copy link
Contributor Author

aplavin commented Mar 17, 2020

Ok, I just thought this is an accidental omission, i.e. someone just forgot to add these functions to the list. For now the choice of which math functions propagate missing and which don't seems arbitrary for me.

@KristofferC
Copy link
Sponsor Member

For now the choice of which math functions propagate missing and which don't seems arbitrary for me.

Indeed, that is the crux of it.

@ararslan ararslan added needs compat annotation Add !!! compat "Julia x.y" to the docstring needs tests Unit tests are required for this change labels Mar 18, 2020
@JeffBezanson
Copy link
Sponsor Member

A possible solution here is just to remove the type restriction from

rad2deg(z::Number) = (z/pi)*180
deg2rad(z::Number) = (z*pi)/180

@aplavin aplavin closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs compat annotation Add !!! compat "Julia x.y" to the docstring needs tests Unit tests are required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants