Clarify type parameters #35971
Closed
Clarify type parameters #35971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make the list of possible type parameters easier to find and easier to parse. See also https://discourse.julialang.org/t/using-type-system-for-different-coordinate-systems/39722.
Contributor
Author
|
Bump |
Member
StefanKarpinski
left a comment
StefanKarpinski
left a comment
There was a problem hiding this comment.
On the whole this feels like a somewhat random list of things. The first addition is ok since it's clearly not meant to be definitive — it just gives some examples and then refers to another section. The second addition is much more problematic since it gives a seemingly comprehensive list of what types can be parameterized by but the list is not actually comprehensive. If we're going to have a list here, it should either clearly be a list of examples or it should be a comprehensive description of what can be used as a parameter.
Co-authored-by: Stefan Karpinski <stefan@karpinski.org>
ettersi
commented
Dec 16, 2020
|
|
||
| All declared types (the `DataType` variety) can be parameterized, with the same syntax in each | ||
| case. We will discuss them in the following order: first, parametric composite types, then parametric | ||
| All declared types (the `DataType` variety) can be parameterized by the following objects. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| All declared types (the `DataType` variety) can be parameterized by the following objects. | |
| All declared types (the `DataType` variety) can be parameterized by the following objects (as well as a few other, more niche objects). |
Contributor
Author
|
Ok, so two options to resolve this:
The first option seems more ideal to me, but the second one is the easy way out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the list of possible type parameters easier to find and easier to parse.
See also https://discourse.julialang.org/t/using-type-system-for-different-coordinate-systems/39722.