more precise inference of splatnew
#35976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
May 21, 2020
Contributor
|
I wonder if we can have the ability to disable constant folding for a few arguments. This will help the compile time for functions with default arguments. |
This allows constant-folding NamedTuple constructors, in turn allowing constant prop through keyword arguments.
JeffBezanson
force-pushed
the
jb/kw_const_prop
branch
from
04cc670 to
30977b4
Compare
Member
|
Can this make it into v1.5 or is that unsafe? |
26 tasks
ChrisRackauckas
added a commit
to ChrisRackauckas/julia
that referenced
this pull request
Jun 15, 2020
I think JuliaLang#35976 is a pretty big deal since it makes all of SciML suddenly infer a lot better, and probably another big library that's splatting keyword arguments. So I added a note to the compiler/runtime improvements.
JeffBezanson
pushed a commit
that referenced
this pull request
Jun 15, 2020
I think #35976 is a pretty big deal since it makes all of SciML suddenly infer a lot better, and probably another big library that's splatting keyword arguments. So I added a note to the compiler/runtime improvements.
JeffBezanson
added a commit
that referenced
this pull request
Jun 18, 2020
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
This allows constant-folding NamedTuple constructors, in turn allowing constant prop through keyword arguments.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 11, 2020
I think JuliaLang#35976 is a pretty big deal since it makes all of SciML suddenly infer a lot better, and probably another big library that's splatting keyword arguments. So I added a note to the compiler/runtime improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows constant-folding NamedTuple constructors, in turn allowing constant prop through keyword arguments.
This might make the compiler very slightly slower, but fortunately I don't see a significant effect, maybe half a second building Base. The extra type info definitely seems worth it.