Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS lazily saves the AVX512 context #36330

Merged
merged 1 commit into from Jun 18, 2020
Merged

macOS lazily saves the AVX512 context #36330

merged 1 commit into from Jun 18, 2020

Conversation

YingboMa
Copy link
Contributor

Fix #36329

yuyichao
yuyichao requested changes Jun 17, 2020
View reviewed changes
src/processor_x86.cpp Outdated Show resolved Hide resolved
src/processor_x86.cpp Show resolved Hide resolved
yuyichao
yuyichao approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@yuyichao yuyichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do note that since it seems that loop vectorizer might be involved there'll still be other issues that you'll need to hack around until it is moved to the LLVM level.

@vchuravy
Copy link
Sponsor Member

We should also back-port the llvm patch.

@Keno
Copy link
Member

Keno commented Jun 17, 2020

This seems like a terrible idea on their part, but I guess it's what we have to do.

@yuyichao
Copy link
Contributor

IIUC it sounds like they are reimplementing xsave. It's pretty unfortunate that they deviate from the intel document...

I assume it also means that running a darwin vm that doesn't support avx512 on hardware that does is basically unsupported then... (which is probably something that apple couldn't care less about...)

@chriselrod chriselrod mentioned this pull request Jun 17, 2020
Closed
@Keno Keno merged commit d19a279 into JuliaLang:master Jun 18, 2020
@Keno
Copy link
Member

Keno commented Jun 18, 2020

I doubt this is the last we've heard along these lines, but let's try this for now, since it matches LLVM.

@YingboMa YingboMa deleted the myb/avx512 branch June 18, 2020 19:43
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Jun 28, 2020
@YingboMa @simeonschaub
macOS lazily saves the AVX512 context (JuliaLang#36330)
f661f03
simeonschaub pushed a commit to simeonschaub/julia that referenced this pull request Aug 11, 2020
@YingboMa @simeonschaub
macOS lazily saves the AVX512 context (JuliaLang#36330)
97e3840
@YingboMa
Copy link
Contributor Author

YingboMa commented Sep 9, 2020

Is it possible to back port this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyichao yuyichao yuyichao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LLVM-9.0.1 doesn't recognize AVX-512 in macOS
4 participants
@YingboMa @vchuravy @Keno @yuyichao