Skip to content

make sign(pi) work #37949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2022
Merged

make sign(pi) work #37949

merged 1 commit into from
Feb 25, 2022

Conversation

@Moelf
Copy link
Contributor

@Moelf Moelf commented Oct 8, 2020

fix #37931

@Moelf
Copy link
Contributor Author

Moelf commented Oct 8, 2020

just leave it here for discussion, it's conceptually annoying to me.
This fix is not perfect, because now one(pi) !== sign(pi). But fixing one(pi) to 1.0 will be a breaking change?

JeffBezanson
JeffBezanson reviewed Oct 8, 2020
View reviewed changes
@Moelf Moelf requested a review from JeffBezanson October 8, 2020 17:09
petvana
petvana reviewed Oct 16, 2020
View reviewed changes
fingolfin
fingolfin reviewed Jan 2, 2021
View reviewed changes
@StefanKarpinski
Copy link
Member

StefanKarpinski commented Mar 23, 2021

Bump? This seems reasonable to me.

@Moelf Moelf changed the title make sign(pi) work make sign(pi) work Mar 24, 2021
@Moelf
Copy link
Contributor Author

Moelf commented Sep 17, 2021 •
edited
Loading

half-year gentle bump

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Sep 17, 2021

Is closing and reopening the pull request still a way to restart CI?

@oscardssmith
Copy link
Member

oscardssmith commented Feb 24, 2022

can we rebase and merge?

@Moelf Moelf requested review from a team and DilumAluthge as code owners February 24, 2022 22:10
@DilumAluthge DilumAluthge removed request for a team and DilumAluthge February 24, 2022 22:22
stevengj
stevengj reviewed Feb 24, 2022
View reviewed changes
@ViralBShah ViralBShah added maths Mathematical functions merge me PR is reviewed. Merge when all tests are passing labels Feb 25, 2022
@DilumAluthge DilumAluthge merged commit 9b8253c into JuliaLang:master Feb 25, 2022
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Feb 25, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
@Moelf @staticfloat
irrational sign() (JuliaLang#37949)
473d430
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@Moelf @LilithHafner
irrational sign() (JuliaLang#37949)
d9be4bb
@Moelf Moelf deleted the irr_sign branch April 29, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fingolfin fingolfin fingolfin left review comments

@ViralBShah ViralBShah ViralBShah left review comments

@stevengj stevengj stevengj left review comments

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

+2 more reviewers

@petvana petvana petvana left review comments

@carstenbauer carstenbauer carstenbauer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

maths Mathematical functions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sign(pi) errors

10 participants

@Moelf @StefanKarpinski @oscardssmith @carstenbauer @fingolfin @ViralBShah @JeffBezanson @stevengj @petvana @DilumAluthge