Provide sparse matrix contructors that convert types efficiently #38315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschnett
force-pushed
the
eschnett/sparse-constructors
branch
from
8611b7f to
25f7e3e
Compare
Member
|
It seems to me like we could go for a more generic approach to this fix, where we have 1 constructor for all matrices they just iterates over and fills nnz values. |
Contributor
Author
|
@oscardssmith How do you iterate over the non-zero values? These constructors take (bi-,tri-)diagonal matrices as input. Is there a generic way to iterate over their nonzero values? |
Contributor
Author
|
Test failures are unrealated. |
Member
|
Never mind on this. I thought this was a generic interface we had, but we only have it for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38209.