Skip to content

fix #38386, macro defining empty function with escaped name #38402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2020
Merged

fix #38386, macro defining empty function with escaped name #38402

merged 1 commit into from
Nov 23, 2020

Conversation

@JeffBezanson
Copy link
Member

@JeffBezanson JeffBezanson commented Nov 11, 2020

fix #38386

@JeffBezanson JeffBezanson added bugfix This change fixes an existing bug macros @macros labels Nov 11, 2020
@JeffBezanson JeffBezanson added the merge me PR is reviewed. Merge when all tests are passing label Nov 21, 2020
@JeffBezanson JeffBezanson merged commit 349e072 into master Nov 23, 2020
@JeffBezanson JeffBezanson deleted the jb/fix38386 branch November 23, 2020 21:39
@simeonschaub
Copy link
Member

simeonschaub commented Dec 10, 2020

Would it make sense to backport this?

@KristofferC
Copy link
Member

KristofferC commented Dec 10, 2020

To what?

@simeonschaub
Copy link
Member

simeonschaub commented Dec 10, 2020

1.5, or is there even going to be a 1.5.4 release?

@KristofferC
Copy link
Member

KristofferC commented Dec 10, 2020

Ah, 1.5. Can add a backport label in case.

@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 11, 2021
@vchuravy vchuravy mentioned this pull request Jan 21, 2021
Merged
27 tasks
Sacha0 pushed a commit that referenced this pull request Jan 21, 2021
@JeffBezanson @Sacha0
fix #38386, macro defining empty function with escaped name (#38402)
e8b16f7
vchuravy pushed a commit that referenced this pull request Jan 22, 2021
@JeffBezanson @vchuravy
fix #38386, macro defining empty function with escaped name (#38402)
d179f48
@laborg laborg mentioned this pull request Feb 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix This change fixes an existing bug macros @macros

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

defining empty function with escaped name in macro does not work

6 participants

@JeffBezanson @simeonschaub @KristofferC @DilumAluthge @Sacha0