require (using, import): give a hint in error message if typo in module name #38724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
You need to replace |
Contributor
Author
|
Thx - german :-).
I have still failures with two ci tests and dont know what the problem is.
David P. Sanders <notifications@github.com> schrieb am So., 31. Jän. 2021,
23:34:
… You need to replace modul with module.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#38724 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF57PELTGXNSEXPZDSJYEOTS4XLHJANCNFSM4UOZLQRA>
.
|
strickek
changed the title
Contributor
Author
|
@KristofferC, pls have a look. Thx |
Contributor
Author
|
The code is working local, but I find no solution to overcome this 3 failing checks. So I close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #38604
I tried to keep it simple and avoid deps with REPL and Pkg.
The tests cover now this exception of require - so coverage should be better a little bit.