lowering: remove incorrect comprehension eta reduction #39139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But keep it for `[f(_) for _ in x]`, since that would now triggers a deprecation error (which was previously incorrectly missing for _). Fixes #18621
JeffBezanson
reviewed
Jan 7, 2021
JeffBezanson
reviewed
Jan 7, 2021
| `(,@(map (lambda (v) `(local ,v)) myvars) | ||
| (= (tuple ,@vars) ,argname)))))) | ||
| (cond | ||
| ((eq? expr argname) |
Member
There was a problem hiding this comment.
Ah, looks like another case where we will need to eventually deprecate _.
Member
Author
There was a problem hiding this comment.
I added a test for this one, since I was not sure it needed to be deprecated. But we can decide that later.
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
But keep it for `[f(_) for _ in x]`, since that would now triggers a deprecation error (which was previously incorrectly missing for _). Fixes JuliaLang#18621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But keep it for
[f(_) for _ in x], since that would now triggers adeprecation error (which was previously incorrectly missing for _).
Fixes #18621