-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Make istriu, istril, and pinv more gpu friendly #39756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Bump. cc @maleadt |
oscardssmith
approved these changes
May 7, 2021
Member
oscardssmith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes!
maleadt
approved these changes
May 8, 2021
Member
maleadt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* Make istriu,istril, and pinv more gpu friendly
dghosef
pushed a commit
to dghosef/julia
that referenced
this pull request
May 11, 2021
* Make istriu,istril, and pinv more gpu friendly
shirodkara
pushed a commit
to shirodkara/julia
that referenced
this pull request
Jun 9, 2021
* Make istriu,istril, and pinv more gpu friendly
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
* Make istriu,istril, and pinv more gpu friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow CUDA.jl to use the
pinvcode from LinearAlgebra (it will call to a specialized version ofsvd!).Fixes JuliaGPU/CUDA.jl#883